A fix was recently committed to both Drupal 8 and Drupal 7 to use #attached for block_admin_display_form() instead of drupal_add_css(). It only came up in my "Your issues" block on my drupal.org dashboard because, it turned out, i was the one who had initially complained about it. And that's all i did- looking for core examples to tell readers of dgd7.org how to write good code, i noticed core was in fact doing it wrong.
The key problem identified is that incentive to abandon code quality to meet time/budget and feature goals.
The solution is to, first, not allow tests, in code, automated, or human, and other issues of code quality to be cut off from the features that are being built. Hide the time in the task estimates if absolutely necessary.
It takes a very long (and enlightening and entertaining and informative) article to get there, but Jeff Eaton makes the key point which i think we all know in Drupal but can have trouble expressing. This is the key big picture for very many of our Drupal 8 initiatives:
The McCabe Cyclomatic Complexity metric (which counts the number of different executable paths through a module) proves to be an excellent measure of code quality. The more paths through a program, the more complicated it is, and the more bugs the program is likely to have.
Situation: You have lots of content that you don't really want in a menu at all, but you want to appear to be below or within a section of the site when you are viewing that content. For instance, when viewing news content the menu link for the overall views listing should appear to be active, or rather in the active path or trail.
Except where otherwise noted, content on this site is licensed under a Creative Commons Attribution 3.0 Unported License.
