Home ›
Core mentoring, and xjm's guide to patch reviewsCore mentoring, and xjm's guide to patch reviews
Submitted by Benjamin Melançon on March 31, 2012 - 8:27am
Link Title and URL:
Core mentoring, and xjm's guide to patch reviews | xjm
- Does it fix the problem without introducing regressions?
- Does it have tests?
- Are the docs and code style OK?
- Does it remain within scope?
- Is it the best fix we can come up with?
And then she goes into loads of awesome detail, such as that interface changes need browser testing and screenshots, reading backwards first to get the code style and comment issues out of the way before thinking about the quality of the code, and using the core gates mentally.
This is long-awaited, in some ways more thorough yet in others more realistic, followup to Angie Byron's epic six-pass patch review, so what are you waiting for? Read XJM's patch review process!
Comments
Post new comment